Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option if to use collection/publication/subscription #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option if to use collection/publication/subscription #19

wants to merge 2 commits into from

Conversation

vonrussel
Copy link

  • added option if to use collection as route settings source, publication, and subscription (default to false -- must be)
  • move some methods under SEO instance `(getCurrentRouteName, escapeHtmlAttribute)``
  • it automatically creates Deps.autoruns if config is executed with settings of use_collection: true

I would gladly appreciate if you look into this. Thanks man!

@manuel-schoebel
Copy link
Owner

Hi @vonrussel, sry for the late response. I did not forget this PR and will look into it, hopefully sometime soon!

@johanbrook
Copy link

This would be super helpful. Right now, the current code is clearing all my SEO stuff, since it runs in an autorun and looks from docs in the SEO collection, but runs SEO.set({}) if there aren't any.

@jsbranco
Copy link

jsbranco commented Feb 9, 2016

@DerMambo Was wondering what happened to this request afterwards?
As I currently don't use collection and i see it setting SEO.set({})..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vonrussel @manuel-schoebel @johanbrook @jsbranco